Skip to content

Fix issue exporting graph with multi-GPU #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Conversation

harperj
Copy link
Contributor

@harperj harperj commented Sep 16, 2019

Our multi-GPU training had a regression such that freezing the
graph was broken. This change fixes that issue by making a few
changes:

  • Removes the top level "tower" variable scope added by multi-GPU
    so that the output nodes have correct names
  • Removes the use of "freeze_graph" and updates the tensorflow to
    barracuda converter to accept GraphDef objects
  • Adds the "auto reuse" to network layers which require them

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ harperj
❌ harper-u3d
You have signed the CLA already but the status is still pending? Let us recheck it.

@harperj
Copy link
Contributor Author

harperj commented Sep 18, 2019

Updated this PR to remove changes to tensorflow_to_barracuda.py by simply writing out the frozen graph definition using the same approach as the freeze_graph function from Tensorflow. I've tested that Barracuda inference on a saved .nn model and also restarting training using --load still work as expected.

harper-u3d and others added 4 commits September 18, 2019 14:18
Our multi-GPU training had a regression such that freezing the
graph was broken.  This change fixes that issue by making a few
changes:

* Removes the top level "tower" variable scope added by multi-GPU
  so that the output nodes have correct names
* Removes the use of "freeze_graph" and updates the tensorflow to
  barracuda converter to accept GraphDef objects
* Adds the "auto reuse" to network layers which require them
@harperj harperj force-pushed the develop-fix-multigpu-save branch from c461a25 to 9d6f356 Compare September 18, 2019 21:19
@chriselion chriselion self-requested a review September 18, 2019 21:36
@harperj harperj merged commit 5fc2fb2 into develop Sep 19, 2019
@harperj harperj deleted the develop-fix-multigpu-save branch October 1, 2019 16:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants