Skip to content

ML-Agents Branding & Color Updates #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Sep 24, 2019
Merged

ML-Agents Branding & Color Updates #2583

merged 41 commits into from
Sep 24, 2019

Conversation

Hunter-Unity
Copy link
Contributor

  • Dark Theme
  • Colors are now standardized across all environments
  • BananaCollector env & scripts renamed to FoodCollector
  • Unity branding added to each scene
  • Hallway now uses symbol targets instead of color targets
  • Added template scene with standard colors/styles/prefabs
  • 3DBall env now balances ball on agent's head

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@surfnerd
Copy link
Contributor

looks like there are bunch of files with ~blah at the end of them. Were those meant to be checked in?

vincentpierre
vincentpierre previously requested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how you did it, but the tag manager asset was not changed in this PR even though I can see the new tags.

vincentpierre
vincentpierre reviewed Sep 19, 2019
View reviewed changes
xiaomaogy
xiaomaogy reviewed Sep 20, 2019
View reviewed changes
@xiaomaogy
Copy link
Contributor

Also maybe you could sign the CLA @Hunter-Unity ?

vincentpierre
vincentpierre reviewed Sep 21, 2019
View reviewed changes
@ervteng ervteng dismissed vincentpierre’s stale review September 23, 2019 23:53

Changes addressed (9/23/2019)

@ervteng ervteng self-requested a review September 23, 2019 23:53
ervteng
ervteng approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! TODO: Update models from latest runs for Crawler and Bouncer

@Hunter-Unity Hunter-Unity merged commit 98ea56a into develop Sep 24, 2019
@vincentpierre vincentpierre deleted the hh/new_env_styles branch October 31, 2019 22:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xiaomaogy xiaomaogy xiaomaogy left review comments

@chriselion chriselion chriselion left review comments

@vincentpierre vincentpierre vincentpierre left review comments

@ervteng ervteng ervteng approved these changes

@awjuliani awjuliani Awaiting requested review from awjuliani

@surfnerd surfnerd Awaiting requested review from surfnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Hunter-Unity @CLAassistant @surfnerd @xiaomaogy @ervteng @chriselion @vincentpierre