Allow mypy to reject incomplete defs for mlagents-envs #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't working before because of several remaining partially defined function definitions.
chriselion
reviewed
Sep 18, 2019
chriselion
reviewed
Sep 18, 2019
chriselion
reviewed
Sep 18, 2019
chriselion
reviewed
Sep 18, 2019
harperj
commented
Sep 18, 2019
| @@ -495,8 +498,6 @@ def step( | |||
| else: | |||
| if text_action[brain_name] is None: | |||
| text_action[brain_name] = [""] * n_agent | |||
| if isinstance(text_action[brain_name], str): | |||
There was a problem hiding this comment.
Note this is an actual functional change. Requires that if we are given a text_action that it will be a Dict[str, List[str]]. Otherwise the types will be inconsistent. I don't believe we use this feature but I thought it was worth noting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't working before because of several remaining partially defined
function definitions.