Skip to content

TensorFlowSharp is no more #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2019
Merged

TensorFlowSharp is no more #2590

merged 2 commits into from
Sep 19, 2019

Conversation

vincentpierre
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chriselion
Copy link
Contributor

You can get rid of https://github.com/Unity-Technologies/ml-agents/blob/develop/docs/Using-TensorFlow-Sharp-in-Unity.md too

@chriselion
Copy link
Contributor

And this section too
https://github.com/Unity-Technologies/ml-agents/blob/develop/docs/FAQ.md#tensorflowsharp-flag-not-turned-on

chriselion
chriselion approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just do a sweep on the docs too.

@vincentpierre
Copy link
Contributor Author

I left them on purpose since those docs are more migration things. Is the FAQ linked only to the current version ?

@chriselion
Copy link
Contributor

Yeah, I don't think we should refer to removed features in the current FAQ

@awjuliani
Copy link
Contributor

RIP TF#.

@vincentpierre vincentpierre merged commit f3042b5 into develop Sep 19, 2019
@vincentpierre vincentpierre deleted the develop-kill-tfsharp branch September 19, 2019 20:36
@KernelPryanic
Copy link

@vincentpierre @chriselion Guys, I'm just getting into this stuff but can I ask you why are you getting rid off of TF#? I just wanted to research TF# and use it in Unity.

@vincentpierre
Copy link
Contributor Author

@FromZeus We are now using the Unity Inference Engine to do inference within Unity Games. For this reason, we deprecated our support for TF#.

@KernelPryanic
Copy link

@vincentpierre Got it, thank you for the information!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vincentpierre @CLAassistant @chriselion @awjuliani @KernelPryanic