Tick version of API and pypi packages to 10 #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
approved these changes
Sep 24, 2019
chriselion
reviewed
Sep 24, 2019
| @@ -97,7 +97,7 @@ public abstract class Academy : MonoBehaviour | |||
| [SerializeField] | |||
| public BroadcastHub broadcastHub = new BroadcastHub(); | |||
|
|
|||
| private const string k_KApiVersion = "API-9"; | |||
| private const string k_KApiVersion = "API-10"; | |||
There was a problem hiding this comment.
Not sure if we want to increment this since I don't think anything has changed.
There was a problem hiding this comment.
I had the same discussion with Vince during 0.9.0. Our current process is to tick at every version - not sure if we should continue to do so. It's a pain for our developers TBH, esp. if we don't change anything on the C# API side.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.