Run precommit in its own job, cache the data #3094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cache miss: Cache hit (precommit only) Cache hit (precommit + venv) Total time for the run goes from 1:44 uncached to 0:42 cached. |
chriselion
commented
Dec 16, 2019
| @@ -55,14 +55,14 @@ repos: | |||
| types: [markdown] | |||
| - id: check-merge-conflict | |||
| args: [--assume-in-merge] | |||
| - id: check-yaml | |||
There was a problem hiding this comment.
I can back this out, but I it saved me at least one bad config.yml push.
chriselion
changed the title
surfnerd
reviewed
Dec 16, 2019
surfnerd
approved these changes
Dec 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we also make the python unit test jobs dependent on precommit job?
Resolves:
https://jira.unity3d.com/browse/MLA-17
https://jira.unity3d.com/browse/MLA-394