Skip to content

perf: Move sampling checks earlier to reduce overhead #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2025
Merged

perf: Move sampling checks earlier to reduce overhead #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81ef278
move sampling up
sohankshirsagar Oct 22, 2025
b72001c
nextjs update
sohankshirsagar Oct 22, 2025
f5ede6b
remove extra sample
sohankshirsagar Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/instrumentation/libraries/http/Instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,20 +256,6 @@ export class HttpInstrumentation extends TdInstrumentationBase {
return originalHandler.call(this);
}

if (
!shouldSample({
samplingRate: this.tuskDrift.getSamplingRate(),
isAppReady: this.tuskDrift.isAppReady(),
})
) {
logger.debug(
`Skipping server span due to sampling rate`,
url,
this.tuskDrift.getSamplingRate(),
);
return originalHandler.call(this);
}

logger.debug(`[HttpInstrumentation] Creating server span for ${method} ${url}`);
return handleRecordMode({
originalFunctionCall: () => originalHandler.call(this),
Expand Down Expand Up @@ -1313,6 +1299,18 @@ export class HttpInstrumentation extends TdInstrumentationBase {
return (originalEmit: Function) => {
return function (this: Server, eventName: string, ...args: any[]) {
if (eventName === "request") {
// Sample as soon as we can to avoid additional overhead if this request is not sampled
if (self.mode === TuskDriftMode.RECORD) {
if (
!shouldSample({
samplingRate: self.tuskDrift.getSamplingRate(),
isAppReady: self.tuskDrift.isAppReady(),
})
) {
return originalEmit.apply(this, [eventName, ...args]);
}
}

const req = args[0];
const res = args[1];

Expand Down
24 changes: 12 additions & 12 deletions src/instrumentation/libraries/nextjs/Instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,18 @@ export class NextjsInstrumentation extends TdInstrumentationBase {

return (originalHandleRequest: Function) => {
return async function (this: any, req: any, res: any, parsedUrl?: any) {
// Sample as soon as we can to avoid additional overhead if this request is not sampled
if (self.mode === TuskDriftMode.RECORD) {
if (
!shouldSample({
samplingRate: self.tuskDrift.getSamplingRate(),
isAppReady: self.tuskDrift.isAppReady(),
})
) {
return originalHandleRequest.call(this, req, res, parsedUrl);
}
}

const method = req.method || "GET";
const url = req.url || "/";

Expand Down Expand Up @@ -193,18 +205,6 @@ export class NextjsInstrumentation extends TdInstrumentationBase {
return originalHandleRequest.call(this, req, res, parsedUrl);
}

if (
!shouldSample({
samplingRate: self.tuskDrift.getSamplingRate(),
isAppReady: self.tuskDrift.isAppReady(),
})
) {
logger.debug(
`[NextjsInstrumentation] Skipping server span due to sampling rate: ${url}`,
);
return originalHandleRequest.call(this, req, res, parsedUrl);
}

logger.debug(`[NextjsInstrumentation] Creating server span for ${method} ${url}`);
return handleRecordMode({
originalFunctionCall: () => originalHandleRequest.call(this, req, res, parsedUrl),
Expand Down