Skip to content

Conversation

@sohankshirsagar
Copy link
Contributor

@sohankshirsagar sohankshirsagar commented Nov 24, 2025

Note

Wraps Connection.prototype.destroy (no-op in REPLAY) and adds E2E endpoint/tests to exercise destroy, updating run scripts accordingly.

  • Instrumentation (mysql):
    • Wraps Connection.prototype.destroy via _getDestroyPatchFn(); no-op in REPLAY, passthrough in RECORD/DISABLED.
  • E2E tests:
    • Adds GET /test/connection-destroy endpoint in cjs-mysql/src/index.ts and esm-mysql/src/index.ts to validate destroy() behavior.
    • Updates cjs-mysql/run.sh and esm-mysql/run.sh to call the new endpoint; enables cleanup_tusk_files in ESM script.
  • Misc:
    • Minor string/style consistency updates in test servers.

Written by Cursor Bugbot for commit 9eb7614. This will update automatically on new commits. Configure here.

@sohankshirsagar sohankshirsagar merged commit 68d06ea into main Nov 24, 2025
4 checks passed
@sohankshirsagar sohankshirsagar deleted the sohan/mysql-patch-destroy branch November 24, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants