[VEN-3254] Enable vBNB and vFDUSD as Prime markets #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Jun 5, 2025
Comment on lines
+253
to
+254
| 0, | ||
| 0, |
There was a problem hiding this comment.
I think I wouldn't update these distribution speeds. This way, the BTCB and ETH tokens available in the PLP contract, not allocated yet, will be allocated until they are totally consumed. Then, because the PLP won't have any BTCB or ETH tokens not allocated, the effective distribution speed will be zero. wdyt?
| LINK: "0xF8A0BF9cF54Bb92F17374d9e9A321E6a111a51bD", | ||
| lisUSD: "0x0782b6d8c4551B9760e74c0545a9bCD90bdc41E5", | ||
| LTC: "0x4338665CBB7B2485A8855A139b75D5e34AB0DB94", | ||
| LUNA: "0x156ab3346823B651294766e23e6Cf87254d68962", |
| USDe: "0x5d3a1Ff2b6BAb83b63cd9AD0787074081a52ef34", | ||
| USDT: "0x55d398326f99059fF775485246999027B3197955", | ||
| USD1: "0x8d0D000Ee44948FC98c9B98A4FA4921476f08B0d", | ||
| UST: "0x3d4350cD54aeF9f9b2C29435e0fa809957B3F30a", |
GitGuru7
reviewed
Jun 6, 2025
| }); | ||
| }); | ||
|
|
||
| testVip("VIP-508-testnet", await vip509(), { |
There was a problem hiding this comment.
Suggested change
| testVip("VIP-508-testnet", await vip509(), { | |
| testVip("VIP-509", await vip509(), { |
nitpick
| expect(market.exists).to.equal(true); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We could also check for destination in converters.
|
commands LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN