parser: allow utf-8 quoted label names at indetList #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes metricsql compatible with prometheus 3.0 utf-8 query requests. https://github.com/prometheus/proposals/blob/main/proposals/2023-08-21-utf8.md This is follow-up commit for e0dbf51 Related issue: VictoriaMetrics/VictoriaMetrics#7703 Signed-off-by: f41gh7 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 88.87% 88.89% +0.01%
==========================================
Files 11 11
Lines 3650 3655 +5
==========================================
+ Hits 3244 3249 +5
Misses 308 308
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM |
makasim
approved these changes
May 7, 2025
hagen1778
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes metricsql compatible with prometheus 3.0 utf-8 query requests.
https://github.com/prometheus/proposals/blob/main/proposals/2023-08-21-utf8.md
This is follow-up commit for e0dbf51
Related issue:
VictoriaMetrics/VictoriaMetrics#7703