Skip to content

More Visual Studio fixes #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2016
Merged

More Visual Studio fixes #288

merged 1 commit into from
Mar 29, 2016

Conversation

kripken
Copy link
Member

@kripken kripken commented Mar 29, 2016

No description provided.

@kripken kripken merged commit baac207 into master Mar 29, 2016
@jfbastien jfbastien deleted the more-vs-fixes branch March 29, 2016 18:08
@juj
Copy link
Collaborator

juj commented Mar 30, 2016

Thanks - the earlier PR I did fixed build for VS2015, but the Emscripten unit test server has VS2013 Update 3. Tested locally with VS2013 Update 5, which builds current master correctly, so updated the Emscripten buildbot to VS2013 Update 5 as well, hopefully that should fix the remaining build issues.

@kripken
Copy link
Member Author

kripken commented Mar 30, 2016

Great!

I still see an error, looks like it doesn't find the asm2wasm binary. If the last push to incoming doesn't fix it (it will rebuild binaryen), then maybe something went wrong with the VS upgrade or other changes, and maybe emcc --clear-ports on that bot would help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants