Set the binary bit on files we need to open in binary mode #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @juj |
| @@ -29,15 +29,15 @@ | |||
|
|
|||
| namespace wasm { | |||
| template <typename T> | |||
| T read_file(const std::string &filename, bool debug); | |||
| T read_file(const std::string &filename, bool binary, bool debug); | |||
There was a problem hiding this comment.
Could you use an enum instead of a bool?
There was a problem hiding this comment.
It would have just 2 values though, and seem inconsistent with the next param after it, which is a bool?
There was a problem hiding this comment.
It's more about expressing intent: what does binary=false mean? Not a big issue, I just find it easier to document it that way.
There was a problem hiding this comment.
It's a pretty common technique in C/C++ API design. It makes it much easier to understand the call site:
read_file("foo.bar", false, true); // what does this mean?
vs.
read_file("foo.bar", kAsText, kDebug);
|
Fair points. Ok, how about if we merge this (should unbreak a bot) and then fix both args as a followup? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix binaryen on windows, which seems broken on emscripten's windows bot