Skip to content

Prefix make_unique in binaryen_shell, for visual studio workarounds #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2016
Merged

Prefix make_unique in binaryen_shell, for visual studio workarounds #595

merged 1 commit into from
Jun 23, 2016

Conversation

kripken
Copy link
Member

@kripken kripken commented Jun 23, 2016

cc @juj

@kripken kripken force-pushed the wasm_make_unique branch from 7d1ed1e to ba9c551 Compare June 23, 2016 16:50
@kripken
Copy link
Member Author

kripken commented Jun 23, 2016

Travis reports Unable to locate package g++-5 which breaks the builds, unrelated to this PR. But it means we don't have any CI working, so it makes merging tricky. I guess we can wait and see if travis fixes it.

@kripken kripken force-pushed the wasm_make_unique branch 3 times, most recently from bd0c4cc to b6b6e60 Compare June 23, 2016 18:26
@kripken
Copy link
Member Author

kripken commented Jun 23, 2016

Added a commit that removes our dependency on g++5. No more test coverage for g++ is the main downside. Also had to add a warning override.

@kripken kripken mentioned this pull request Jun 23, 2016
Closed
@kripken kripken force-pushed the wasm_make_unique branch from b6b6e60 to 46c7fc9 Compare June 23, 2016 19:04
@kripken
Copy link
Member Author

kripken commented Jun 23, 2016

Transient travis error went away.

@kripken kripken merged commit 51e7034 into master Jun 23, 2016
@kripken kripken deleted the wasm_make_unique branch June 23, 2016 20:13
@lqd lqd mentioned this pull request Jun 24, 2016
Closed
ddcc pushed a commit to ddcc/binaryen that referenced this pull request Jun 27, 2016
@kripken @ddcc
prefix make_unique in binaryen_shell for visual studio workarounds (W…
21dd5c7 
…ebAssembly#595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kripken