[Experimental] Measure the space used by vtable pointers #7487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the space that could be saved by using custom descriptors.
kripken
approved these changes
Apr 14, 2025
|
|
||
| // Measure the savings of removing vtable pointers. Assume any object that | ||
| // contains an edge to another object that contains an edge to a "system / | ||
| // WasmFuncRef" contains a vtable pointer. |
There was a problem hiding this comment.
How precise do you think this is?
There was a problem hiding this comment.
I think it should be fairly precise. I don't know of any other patterns involving function references, do you? I have samples with name sections so I can do another analysis where I just look for "vtable" in the type name and compare the results to make sure.
There was a problem hiding this comment.
I can't say I know of one, but I remember talk about caching function pointers in some cases... Good idea to compare to types with "vtable" in the name, yeah, that would give a lot more confidence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the space that could be saved by using custom descriptors.