Update testsuite #1275
Merged
Update testsuite #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
update_testsuite
branch
2 times, most recently
from
c9d15d2 to
b4c17b9
Compare
aardappel
reviewed
Dec 26, 2019
aardappel
reviewed
Dec 26, 2019
aardappel
reviewed
Dec 26, 2019
aardappel
reviewed
Dec 26, 2019
aardappel
approved these changes
Dec 26, 2019
|
This is really important for https://github.com/wasm3/wasm3. |
binji
approved these changes
Jan 8, 2020
|
This change for a little smaller thanks to #1278 |
sbc100
force-pushed
the
update_testsuite
branch
3 times, most recently
from
039160b to
f48eabd
Compare
The two primary changes involved are: 1. Removal of `assert_return_canonical_nan`/`arithetic nan` in favor of special `nan:canonical`/`nan:arithmetic` constants that can only be used in test expectations. See: WebAssembly/spec#1104 2. New trapping behaviour for bulk memory operations. Range checks are now performed up front for opterations such as memory.fill and memory.copy. See: WebAssembly/bulk-memory-operations#111 And: WebAssembly/bulk-memory-operations#123 The old behaviour is still kept around to support table.fill which is defined in reference-types proposal and has yet to be updated. 3. nullref is now permitted in the text and binary format.
sbc100
force-pushed
the
update_testsuite
branch
from
f48eabd to
6335128
Compare
2 tasks
|
Thanks! The updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two primary changes involved are:
Removal of
assert_return_canonical_nan/arithetic nanin favor ofspecial
nan:canonical/nan:arithmeticconstants that can only beused in test expectations.
See: [interpreter] Unify assert_result* assertions spec#1104
New trapping behaviour for bulk memory operations. Range checks are
now performed up front for opterations such as memory.fill and
memory.copy.
See: memory.copy|fill semantics limit optimizations for short constant lengths bulk-memory-operations#111
And: [exec] Bounds check bulk-memory before execution bulk-memory-operations#123
The old behaviour is still kept around to support table.fill which
is defined in reference-types proposal and has yet to be updated.