REGRESSION (STP 164): new failure in css/css-backgrounds/parsing/background-shorthand-serialization.html #11087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 5165dce)
|
nt1m
approved these changes
Mar 5, 2023
…ground-shorthand-serialization.html https://bugs.webkit.org/show_bug.cgi?id=252925 rdar://problem/106208628 Reviewed by Tim Nguyen. Revert the change from https://commits.webkit.org/260157@main that made background-color serialize first. This is being discussed in w3c/csswg-drafts#8496, but while it's discussed, it seems good to change the behavior back since that matches other browsers and some WPT test expectations. * LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt: Change expectations back to expect background-color to be serialized last, after the other longhands that are part of the background shorthand * LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt: Ditto. * LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: Ditto. * LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html: Ditto. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: Ditto. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: Ditto. * LayoutTests/fast/css/remove-shorthand-expected.txt: Ditto. * LayoutTests/fast/dom/background-shorthand-csstext-expected.txt: Ditto. * LayoutTests/fast/dom/background-shorthand-csstext.html: Ditto. * Source/WebCore/css/CSSProperties.json: Move background-color to the end of the list of longhands for the background shorthand. Canonical link: https://commits.webkit.org/261250@main
webkit-early-warning-system
force-pushed
the
eng/REGRESSION-STP-164-new-failure-in-csscss-backgroundsparsingbackground-shorthand-serialization-html
branch
from
5165dce to
bec59bd
Compare
|
Committed 261250@main (bec59bd): https://commits.webkit.org/261250@main Reviewed commits have been landed. Closing PR #11087 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
darinadler
deleted the
eng/REGRESSION-STP-164-new-failure-in-csscss-backgroundsparsingbackground-shorthand-serialization-html
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bec59bd
5165dce
🧪 mac-wk2-stress