Skip to content

[view-transitions] Skip view transition on hidden pages #26191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2024
Merged

[view-transitions] Skip view transition on hidden pages #26191

merged 1 commit into from
Sep 3, 2024

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Mar 20, 2024 •
edited by webkit-early-warning-system
Loading

d985c51

[view-transitions] Skip view transition on hidden pages
https://bugs.webkit.org/show_bug.cgi?id=271248
rdar://125017653

Reviewed by Matt Woodrow.

Follow:
- https://drafts.csswg.org/css-view-transitions-1/#page-visibility-change-steps
- w3c/csswg-drafts#9543

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/transition-in-hidden-page-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/transition-in-hidden-page.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-before-ready.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations: Remove duplicate test expectations to reduce confusion.
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::visibilityStateChanged): Make this more robust to allow unregistering clients while iterating.
(WebCore::Document::resolveViewTransitionRule):
(WebCore::Document::reveal):
(WebCore::Document::startViewTransition):
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::ViewTransition):
(WebCore::ViewTransition::stop):
(WebCore::ViewTransition::visibilityStateChanged):
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/283084@main

89117a2

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from rniwa and cdumez as code owners March 20, 2024 15:22
@nt1m nt1m self-assigned this Mar 20, 2024
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Mar 20, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 145795b to 39e24eb Compare March 20, 2024 15:58
@nt1m nt1m requested review from smfr, mattwoodrow and annevk March 20, 2024 15:59
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 20, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 145795b)

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
  🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-skia
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch ⏳ 🛠 jsc-armv7
  🛠 watch-sim ⏳ 🧪 jsc-armv7-tests

@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 39e24eb to ba502c4 Compare March 20, 2024 20:25
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 20, 2024 •
edited
Loading

EWS run on previous version of this PR (hash ba502c4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 21, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Apr 4, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from ba502c4 to b6c40df Compare April 4, 2024 07:03
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 4, 2024 •
edited
Loading

EWS run on previous version of this PR (hash b6c40df)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
loading-orange 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-cairo
loading 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m marked this pull request as draft April 15, 2024 21:50
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from b6c40df to 0751754 Compare June 11, 2024 00:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 0751754)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 11, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Jun 11, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 0751754 to a5582c7 Compare June 11, 2024 02:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash a5582c7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
  🛠 tv ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
  🛠 tv-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
  🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 11, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Jun 11, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from a5582c7 to 8481719 Compare June 11, 2024 02:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 8481719)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 11, 2024
@nt1m nt1m mentioned this pull request Aug 29, 2024
Merged
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Sep 3, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 8481719 to 2e66344 Compare September 3, 2024 00:05
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 2e66344)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ⏳ 🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv
  🛠 tv-sim
✅ 🛠 watch
  🛠 watch-sim

@nt1m nt1m marked this pull request as ready for review September 3, 2024 00:06
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 2e66344 to 8479b8c Compare September 3, 2024 00:36
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 8479b8c)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 8479b8c to 7c521eb Compare September 3, 2024 00:39
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 7c521eb)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 3, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Sep 3, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 7c521eb to 5d1cde0 Compare September 3, 2024 05:22
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 5d1cde0)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
  🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue labels Sep 3, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 5d1cde0 to 89117a2 Compare September 3, 2024 06:47
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Sep 3, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

EWS run on current version of this PR (hash 89117a2)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m
[view-transitions] Skip view transition on hidden pages
d985c51 
https://bugs.webkit.org/show_bug.cgi?id=271248
rdar://125017653

Reviewed by Matt Woodrow.

Follow:
- https://drafts.csswg.org/css-view-transitions-1/#page-visibility-change-steps
- w3c/csswg-drafts#9543

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/transition-in-hidden-page-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/transition-in-hidden-page.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-before-ready.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations: Remove duplicate test expectations to reduce confusion.
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::visibilityStateChanged): Make this more robust to allow unregistering clients while iterating.
(WebCore::Document::resolveViewTransitionRule):
(WebCore::Document::reveal):
(WebCore::Document::startViewTransition):
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::ViewTransition):
(WebCore::ViewTransition::stop):
(WebCore::ViewTransition::visibilityStateChanged):
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/283084@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/view-transitions-Skip-view-transition-on-hidden-pages branch from 89117a2 to d985c51 Compare September 3, 2024 07:13
@webkit-commit-queue
Copy link
Collaborator

Committed 283084@main (d985c51): https://commits.webkit.org/283084@main

Reviewed commits have been landed. Closing PR #26191 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d985c51 into WebKit:main Sep 3, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez left review comments

@mattwoodrow mattwoodrow mattwoodrow approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@smfr smfr Awaiting requested review from smfr

@annevk annevk Awaiting requested review from annevk

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @cdumez @mattwoodrow @webkit-ews-buildbot