Skip to content

[css-logical] split logical shorthand relative prioritization animation test off from css/css-logical/animation-001.html as a dedicated tentative test #32929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Aug 30, 2024

f87a800

[css-logical] split logical shorthand relative prioritization animation test off from css/css-logical/animation-001.html as a dedicated tentative test
https://bugs.webkit.org/show_bug.cgi?id=278910
rdar://135006627

Reviewed by Anne van Kesteren.

Given the `logical` keyword for the `margin` shorthand, and other relative shorthands, is not stable yet,
as discussed in w3c/csswg-drafts#1282, we split off the test in
`css/css-logical/animation-001.html` that relies on this feature and make a new test file marked `.tentative`.

* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/logical-shorthand-relative-prioritization-by-number-of-components.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/logical-shorthand-relative-prioritization-by-number-of-components.tentative.html: Added.

Canonical link: https://commits.webkit.org/282961@main

dd293f9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@graouts graouts self-assigned this Aug 30, 2024
@graouts graouts added the CSS Cascading Style Sheets implementation label Aug 30, 2024
@graouts graouts requested a review from annevk August 30, 2024 10:36
@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 30, 2024
…on test off from css/css-logical/animation-001.html as a dedicated tentative test

https://bugs.webkit.org/show_bug.cgi?id=278910
rdar://135006627

Reviewed by Anne van Kesteren.

Given the `logical` keyword for the `margin` shorthand, and other relative shorthands, is not stable yet,
as discussed in w3c/csswg-drafts#1282, we split off the test in
`css/css-logical/animation-001.html` that relies on this feature and make a new test file marked `.tentative`.

* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/logical-shorthand-relative-prioritization-by-number-of-components.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/logical-shorthand-relative-prioritization-by-number-of-components.tentative.html: Added.

Canonical link: https://commits.webkit.org/282961@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/css-logical-split-logical-shorthand-relative-prioritization-animation-test-off-from-csscss-logicalanimation-001-html-as-a-dedicated-tentative-test branch from dd293f9 to f87a800 Compare August 30, 2024 12:22
@webkit-commit-queue
Copy link
Collaborator

Committed 282961@main (f87a800): https://commits.webkit.org/282961@main

Reviewed commits have been landed. Closing PR #32929 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f87a800 into WebKit:main Aug 30, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 30, 2024
@graouts graouts deleted the eng/css-logical-split-logical-shorthand-relative-prioritization-animation-test-off-from-csscss-logicalanimation-001-html-as-a-dedicated-tentative-test branch August 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants