::first-letter should include preceding punctuation and space separators

[johannesodland]

2bceb0e

::first-letter should include preceding punctuation and space separators
https://bugs.webkit.org/show_bug.cgi?id=179815

Reviewed by NOBODY (OOPS!).

Updating the punctuation and whitespace characters that are included preceding and following the first-letter
according to https://www.w3.org/TR/css-pseudo-4/#first-letter-pattern.
This change makes first-letter-punctuation-and-space.html pass.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::isPrecedingPunctuationForFirstLetter):
(WebCore::isFollowingPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
(WebCore::isPunctuationForFirstLetter): Deleted.

5d194cf

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 2bceb0e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	🛠 wpe-cairo
🛠 🧪 jsc	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 1f36172)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[fantasai]

Not all space characters are allowed -- we still have to exclude U+3000 IDEOGRAPHIC SPACE, but also allow the rest of of Zs!

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 6a8ffe7)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	⏳ 🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash f637b31)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	⏳ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 56eacd3)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	🛠 wpe	🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	⏳ 🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	🛠 mac-safer-cpp	🛠 jsc-armv7
	✅ 🛠 tv-sim		🧪 jsc-armv7-tests
	🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 5d194cf)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

[johannesodland]

Not all space characters are allowed -- we still have to exclude U+3000 IDEOGRAPHIC SPACE, but also allow the rest of of Zs!

I tried to avoid changing the whitespace logic too much, but we might just update it now 😅

I have pushed an update to the PR to align with the updated First Letters and Associated Punctuation chapter in the spec.

It should pass the updated web platform test (yet to be reviewed).

[johannesodland]

I realize that we also have to consume the white-space before the preceding punctuation. Otherwise ::first-letter will not work in cases such as below:

<p>
  The initial T-character should ble included in `::first-letter`.
</p>

@fantasai , I expect the preceding white-spaces also should be included in the ::first-letter as that is how webkit currently works.

Which letters should be allowed to precede the punctuation? Does this need to be specced?