Site Editor: Check user permissions before rendering export menu item #69971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
changed the title
Mamaduka
commented
Apr 23, 2025
Comment on lines
+22
to
+24
| 'targetHints' => array( | ||
| 'allow' => current_user_can( 'export' ) ? array( 'GET' ) : array(), | ||
| ), |
There was a problem hiding this comment.
Ideally, this should use the same method as self links, but I went with KISS for now 😄 Maybe in the future we can introduce a flag to opt-in targetHints generation for any rel link.
@TimothyBJacobs, what do you think?
gutenberg/lib/compat/wordpress-6.7/class-gutenberg-rest-server.php
Lines 86 to 90 in accde16
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Apr 23, 2025
Comment on lines
+15
to
+20
| const targetHints = | ||
| select( coreStore ).getCurrentTheme()?._links?.[ | ||
| 'wp:export-theme' | ||
| ]?.[ 0 ]?.targetHints ?? {}; | ||
|
|
||
| return !! targetHints.allow?.includes( 'GET' ); |
There was a problem hiding this comment.
Dropped is_block_theme theme condition check; this link is only available for block themes. See PHP response filter.
|
Size Change: +41 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
spacedmonkey
approved these changes
May 2, 2025
|
Thank you, @spacedmonkey! |
Mamaduka
force-pushed
the
try/themes-export-link-rel
branch
from
c7b80b4 to
4f1ec55
Compare
|
Flaky tests detected in 4f1ec55. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14831730488
|
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#69971) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: spacedmonkey <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: unsalkorkmaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #46661.
Supersedes #69107.
Related https://core.trac.wordpress.org/ticket/57379.
PR adds a user capability check for the Export feature in the Site Editor. Users without export capabilities will not be able to use this feature.
How
Add a new link relation for the export endpoint and provide the required data for capability checks via
targetHints. Suggested initially by @TimothyBJacobs - https://core.trac.wordpress.org/ticket/57379#comment:10.Testing Instructions
exportcap for Administrators -wp cap remove administrator export.wp role reset administratorTesting Instructions for Keyboard
Same.
Screenshots or screencast