-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Playwright e2e test for filtering media by type #7946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Thanks for the first pass on this. I think it needs to be expanded a bit before it's ready. I would like to see an additional type besides image that is uploaded and that test to ensure that the correct number of items is in the media directory before filtering and then at each step of the way (i.e. if an mp3 is uploaded along with the two images, check that there are 3 normally, 1 with audio, 0 with video, and 2 with image) |
Also, it would be nice to not only test the grid view but also test the list view |
Hi @aaronjorbin I have made the requested changes. Can you please recheck? |
Generally with Playwright one should avoid using CSS class locators as much as possible. Use methods such as |
@swissspidy I have updated the locators except one as it does not have any additional attributes to refer to. |
Playwright e2e test for filtering media by type
Trac ticket: https://core.trac.wordpress.org/ticket/52895
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.