Skip to content

Increase shared user fixtures following switch to bcrypt hashing. #8657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: trunk
Choose a base branch
from

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Apr 7, 2025

Modifies a bunch of test suite users to be created as shared fixtures.

As there are a lot of uniquely generated fixtures, I think this ticket would best be served by working on the issue piecemeal rather than fixing the issue all at once.

These initial changes seem to have cut a few minutes off the test run but there's more to be done.

Trac ticket: https://core.trac.wordpress.org/ticket/63026


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Apr 7, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc peterwilsoncc force-pushed the try/some-shared-user-fixtures branch from 302160d to 9a0dc88 Compare April 7, 2025 23:07
@peterwilsoncc peterwilsoncc force-pushed the try/some-shared-user-fixtures branch from e639e57 to c0473fd Compare May 5, 2025 02:22
@peterwilsoncc peterwilsoncc changed the title Some shared user fixtures. Increase shared user fixtures following switch to bcrypt hashing. May 5, 2025
@peterwilsoncc peterwilsoncc marked this pull request as ready for review May 5, 2025 03:50
Copy link

github-actions bot commented May 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant