Skip to content

Administration: Fix Tags screen UI inconsistencies on add/delete #8761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Administration: Fix Tags screen UI inconsistencies on add/delete #8761

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dcc7aa
Administration: Fix Tags screen 'No tags found' message and tablenav …
SainathPoojary Apr 30, 2025
338d2c7
Administration: Update tag count display in tablenav after adding/rem…
SainathPoojary May 5, 2025
0577a55
Administration: Show search box and tablenav when items are present i…
SainathPoojary May 5, 2025
9f820be
Administration: Adjust tag count handling for pagination consistency
SainathPoojary May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Administration: Adjust tag count handling for pagination consistency
  • Loading branch information
@SainathPoojary
SainathPoojary committed May 6, 2025
commit 9f820be8cc373262a599f7b10b32eccab676a2bc
6 changes: 4 additions & 2 deletions src/js/_enqueues/admin/tags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ jQuery( function($) {
$('p.search-box').hide();
}

var itemCount = $('#the-list tr').length;
var currentCount = parseInt( $('.tablenav-pages .displaying-num').first().text().match(/\d+/) ) || 0;
var itemCount = currentCount - 1 || 0;
var itemText = itemCount === 1 ? wp.i18n.__('item') : wp.i18n.__('items');
$('.tablenav-pages .displaying-num').text( itemCount + ' ' + itemText);
});
Expand Down Expand Up @@ -177,7 +178,8 @@ jQuery( function($) {

$('input:not([type="checkbox"]):not([type="radio"]):not([type="button"]):not([type="submit"]):not([type="reset"]):visible, textarea:visible', form).val('');

var itemCount = $('#the-list tr').length;
var currentCount = parseInt( $('.tablenav-pages .displaying-num').first().text().match(/\d+/) ) || 0;
var itemCount = currentCount + 1 || 0;
var itemText = itemCount === 1 ? wp.i18n.__('item') : wp.i18n.__('items');
$('.tablenav-pages .displaying-num').text( itemCount + ' ' + itemText);

Expand Down
Loading