-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update to Twemoji 16 for Emoji 16 support #8774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This would potentially cause the test to incorrectly fail if the site or UA is using Noto Emoji Font, as it looks like the centre pixel for the shovel would be white. This is an extreme edge case that I usually wouldn't be concerned about, particularly as it hasn't caused any reported issues with the historical smiley used. If you feel like addressing it, it could probably be mitigated by testing with the splatter emoji, instead. |
@peterwilsoncc This looks good to me! |
5e896c2
to
671e057
Compare
Updates to Emoji 16:
emojiRendersEmptyCenterPoint
Shovel Splatter Modesty aside, uses a pretty good pun in the comments@westonruter Would you be able to validate that I am passing the new function around correctly for the support tests to continue working in workers?
@pento I based the test for an empty center point on the tests in the version in the 4.2 branch, do you recall if that caused any problems?
wordpress-develop/src/wp-includes/js/wp-emoji-loader.js
Lines 42 to 48 in d3c5f3a
Trac ticket: https://core.trac.wordpress.org/ticket/63324
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.