Skip to content

Curl extension for the Node.js build of PHP.wasm #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 29, 2024
Merged

Curl extension for the Node.js build of PHP.wasm #1273

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d740f75
BasePHP: Check if (this[__private__dont__use]) before deleting the on…
adamziel Apr 25, 2024
0f27275
Node with Curl extension
Apr 18, 2024
94ec57d
Curl works with PHP 8.0
adamziel Apr 28, 2024
348df3f
Add more ASYNCIFY_ONLY functions
adamziel Apr 28, 2024
d422bca
Rebuild PHP
adamziel Apr 28, 2024
86e2f10
Add RAND_bytes to ASYNCIFY_ONLY
adamziel Apr 28, 2024
ce15bac
Add php_stream_xport_crypto_setup to ASYNCIFY_ONLY, fix unit tests
adamziel Apr 28, 2024
1ddafe3
PHP 7.4+ support for Curl
adamziel Apr 28, 2024
8901573
Libcurl working on all PHP versions
adamziel Apr 29, 2024
ea20f2d
Bring trunk's version of base-php.ts
adamziel Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
BasePHP: Check if (this[__private__dont__use]) before deleting the on… 
…Message handler
  • Loading branch information
@adamziel
adamziel committed Apr 28, 2024
commit d740f75772e0284f30bdcb17abc70321a7e7617f
6 changes: 4 additions & 2 deletions packages/php-wasm/universal/src/lib/base-php.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,8 +872,10 @@ export abstract class BasePHP implements IsomorphicLocalPHP, Disposable {

// Delete any links between this PHP instance and the runtime
this.#wasmErrorsTarget = null;
delete this[__private__dont__use]['onMessage'];
delete this[__private__dont__use];
if (this[__private__dont__use]) {
delete this[__private__dont__use]['onMessage'];
delete this[__private__dont__use];
}
}

[Symbol.dispose]() {
Expand Down