fix flow type for nestedPath #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
codegen generate wrong flow type when I use
nestedPath
.dataloader-config.yaml
Status Quo
The flow type of
response
isany
, which is wrong!after my change in src/genTypeFlow.ts

We get the correct flow type.What's wrong?
If the response is nested in some path, we need to first unwrap it. Then if it's a batch resource, we do
$ElementType<${retVal}, 0>
The order of two if-else statement matters!Test Done
make test passed
Also see my swapi example ^ (screen shot above)