Skip to content

Use standard storage class by default, demonstrate kustomization per hosting provider #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 6, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
36903cf
Defaults to \”standard" storage class for all persistence
solsson May 3, 2019
8f949e4
With the new defaults there'll be no need for minikube storageclasses
solsson May 3, 2019
1bf9744
I haven't used Docker's k8s for a while but
solsson May 3, 2019
5ef2914
Overlays can be based on overlays
solsson May 3, 2019
ba342ee
Merge branch 'combine-kustomizations' into storagclass-kustomize
solsson May 3, 2019
ed0844c
Includes RBAC in variants
solsson May 3, 2019
44717ce
Replaces variant as-is with scale-[brokers]-[zks]
solsson May 3, 2019
d86263f
Regional, i.e. multi-zone, volumes for 2 of 5 zk pods is now a variant
solsson May 3, 2019
1d47004
Updates docs for removal of ./configure and status of apply -f
solsson May 3, 2019
d168b48
Migrates AWS and AKS examples from ./configure to overlays
solsson May 3, 2019
bebd7b8
Cool
solsson May 3, 2019
553f327
Quickstart shouldn't overwrite anything that exists
solsson May 3, 2019
02140ec
Kustomize is a good fit for maintaining a setup over time
solsson May 3, 2019
8a4db1f
Adds a variant with scale 1 + localhost listener + auto topic creation
solsson May 3, 2019
86e760e
Braches work too, if they are misspelt identically :)
solsson May 3, 2019
bfd64ca
Results in a "found conflict between different patches"
solsson May 6, 2019
94c5bed
Duplicates overrides to avoid a Kustomization conflict
solsson May 6, 2019
99fd504
Unsets the JMX_PORT env with the intention of making kafka lighter
solsson May 6, 2019
baa35cf
Reflects some new developments
solsson May 6, 2019
dc7a4a4
The new quickstart section replaces the old "fewer nodes"
solsson May 6, 2019
61555c3
Documents the apply flaw where it happens, see #269
solsson May 6, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Overlays can be based on overlays
solves the duplication pointed out in #266 870435a
  • Loading branch information
solsson committed May 3, 2019
commit 5ef2914b34955ffb96ca9babad76d0cf03667d82
1 change: 0 additions & 1 deletion variants/scale-1-ephemeral/kafka.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ metadata:
name: kafka
namespace: kafka
spec:
replicas: 1
template:
spec:
volumes:
Expand Down
10 changes: 1 addition & 9 deletions variants/scale-1-ephemeral/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
bases:
- ../../kafka
- ../../zookeeper
- ../scale-1
patchesStrategicMerge:
- kafka.yaml
- zookeeper.yaml
patchesJson6902:
- target:
group: apps
version: v1
kind: StatefulSet
name: kafka
path: kafka-scale1-overrides.json
23 changes: 4 additions & 19 deletions variants/scale-1-ephemeral/zookeeper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,8 @@ metadata:
name: pzoo
namespace: kafka
spec:
replicas: 1
template:
spec:
initContainers:
- name: init-config
env:
- name: PZOO_REPLICAS
value: '1'
- name: ZOO_REPLICAS
value: '0'
volumes:
- name: data
emptyDir: {}
Expand All @@ -32,16 +24,9 @@ metadata:
name: zoo
namespace: kafka
spec:
replicas: 0
template:
spec:
initContainers:
- name: init-config
env:
# There's no validation on these numbers adding up to a coherent zk config, so watch out
- name: PZOO_REPLICAS
value: '1'
- name: ZOO_REPLICAS
value: '0'
- name: ID_OFFSET
value: '2'
volumes:
- name: data
emptyDir: {}
volumeClaimTemplates: []