-
Notifications
You must be signed in to change notification settings - Fork 58
Add PIV Bio extensions #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results: Windows 2 files 2 suites 4s ⏱️ Results for commit 438fc41. ♻️ This comment has been updated with latest results. |
Test Results: Ubuntu 2 files 2 suites 9s ⏱️ Results for commit 438fc41. ♻️ This comment has been updated with latest results. |
Test Results: MacOS 2 files 2 suites 4s ⏱️ Results for commit 438fc41. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre approving, added some suggestions that align with the SDK and C# in general. Thanks for the help!
Description
Adds Metadata and Verify extensions for YubiKey Bio MPE.
Adds new slot verification policies (PIN_OR_MATCH_ONCE and PIN_OR_MATCH_ALWAYS).
Type of change
Please delete options that are not relevant.
How has this been tested?
There are new integration tests for verifying that we receive expected data.
Test configuration:
Checklist:
dotnet format
to format my code