Skip to content

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Jun 20, 2024

Description

Adds Metadata and Verify extensions for YubiKey Bio MPE.

Adds new slot verification policies (PIN_OR_MATCH_ONCE and PIN_OR_MATCH_ALWAYS).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

There are new integration tests for verifying that we receive expected data.

Test configuration:

  • Firmware version: 5.6+
  • Yubikey model: YK Bio MPE

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format to format my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Jun 20, 2024

Test Results: Windows

    2 files      2 suites   4s ⏱️
3 700 tests 3 700 ✅ 0 💤 0 ❌
3 702 runs  3 702 ✅ 0 💤 0 ❌

Results for commit 438fc41.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2024

Test Results: Ubuntu

    2 files      2 suites   9s ⏱️
3 692 tests 3 692 ✅ 0 💤 0 ❌
3 694 runs  3 694 ✅ 0 💤 0 ❌

Results for commit 438fc41.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2024

Test Results: MacOS

    2 files      2 suites   4s ⏱️
3 692 tests 3 692 ✅ 0 💤 0 ❌
3 694 runs  3 694 ✅ 0 💤 0 ❌

Results for commit 438fc41.

♻️ This comment has been updated with latest results.

@AdamVe AdamVe marked this pull request as ready for review June 24, 2024 11:23
@AdamVe AdamVe requested a review from DennisDyallo June 24, 2024 11:23
Copy link
Member

@dainnilsson dainnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DennisDyallo DennisDyallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre approving, added some suggestions that align with the SDK and C# in general. Thanks for the help!

@DennisDyallo DennisDyallo added the enhancement New feature or request label Jun 26, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257
Yubico.YubiKey 51% 47% 18999
Summary 49% (31966 / 65643) 44% (8176 / 18444) 23256

Minimum allowed line rate is 40%

@DennisDyallo DennisDyallo merged commit 577d77a into develop Jun 27, 2024
@DennisDyallo DennisDyallo deleted the adamve/bio_extensions branch June 27, 2024 07:54
@DennisDyallo DennisDyallo mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants