Skip to content

Suggested documentation changes to UseFastTrigger #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
+5 −3
Merged

Suggested documentation changes to UseFastTrigger #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Yubico.YubiKey/src/Yubico/YubiKey/Otp/OtpSettings.ExtendedFlags.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,13 @@ public T UseNumericKeypad(bool setting = true) =>
ApplyFlag(Flag.UseNumericKeypad, setting);

/// <summary>
/// Causes the trigger action of the YubiKey button to become faster.
/// Causes the trigger action of the YubiKey button to become faster on early model YubiKeys.
/// </summary>
/// <remarks>
/// This only applies when one configuration is written. If both configurations are active,
/// this setting has no effect.
/// This setting is enabled by default on current generation YubiKeys. As such, the method is
/// maintained for backwards compatibility with older YubiKeys only. Moreover, the fast trigger
/// feature only applies when one slot configuration is written. If both configurations (slot 1 and
/// slot 2) are active / configured, this setting has no effect.
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before the period at the end of the sentence. It should be 'configured, this setting has no effect.' without the extra space.

Suggested change
/// slot 2) are active / configured, this setting has no effect.
/// slot 2) are active / configured, this setting has no effect.

Copilot uses AI. Check for mistakes.

/// </remarks>
public T UseFastTrigger(bool setting = true) =>
ApplyFlag(Flag.FastTrigger, setting);
Expand Down
Loading