Skip to content

Conversation

GregDomzalski
Copy link
Contributor

Description

The YubiKey allows a caller to temporarily adjust the touch threshold which affects the sensitivity of the capacitive touch sensor. It is possible to raise the threshold (thus making the key less sensitive) and more difficult for the touch sensor to activate. This is interesting in automation scenarios where the YubiKey may be in some sort of configuration or test harness. We have found in our own testing that being able to raise the threshold from 6 to about 8 or 9 is able to improve the reliability of our touch automation quite substantially. I am aware of other organizations who have mechanically automated provisioning, so this may prove useful for them too.

Fixes # (internal: PROD1942)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Through updating the test app and verifying that the set command succeeds.

Test configuration:

  • Firmware version: 5.4.3
  • Yubikey model: A NFC

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format to format my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

Test Results: Windows

    2 files      2 suites   2s ⏱️
3 616 tests 3 616 ✅ 0 💤 0 ❌
3 618 runs  3 618 ✅ 0 💤 0 ❌

Results for commit c93f687.

Copy link

Test Results: Ubuntu

    2 files      2 suites   5s ⏱️
3 608 tests 3 608 ✅ 0 💤 0 ❌
3 610 runs  3 610 ✅ 0 💤 0 ❌

Results for commit c93f687.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257
Yubico.YubiKey 51% 47% 18549
Summary 49% (31645 / 64503) 44% (8041 / 18093) 22806

Minimum allowed line rate is 40%

Copy link

Test Results: MacOS

    2 files      2 suites   3s ⏱️
3 608 tests 3 608 ✅ 0 💤 0 ❌
3 610 runs  3 610 ✅ 0 💤 0 ❌

Results for commit c93f687.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File SetDeviceInfoBaseCommsnd.cs line 36, Where do all these tag number coming from? and 0x85 is very different then the other tags

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! They typically come from the internal documentation of the management application which would be provided by the firmware team.

@DennisDyallo DennisDyallo added the enhancement New feature or request label May 29, 2024
@DennisDyallo DennisDyallo merged commit 957e6c3 into develop May 29, 2024
@DennisDyallo DennisDyallo deleted the feature/temp-touch-sensitivity branch May 29, 2024 10:02
@DennisDyallo DennisDyallo mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants