Skip to content

Search algo #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 10, 2019
Merged

Search algo #119

merged 8 commits into from
Nov 10, 2019

Conversation

kdimolikas
Copy link
Contributor

New scope Search (#95)

  • Create new scope Search
  • Implement Binary Search algorithm

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aalhour aalhour added the algorithm request Suggest a new algorithm for this project label Nov 6, 2019
Copy link
Owner

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting, order of sort operation and a missing test case.

Copy link
Owner

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about SearchFor and BinarySearch methods.

@aalhour aalhour merged commit c37e746 into aalhour:master Nov 10, 2019
@kdimolikas kdimolikas deleted the search-algo branch November 10, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm request Suggest a new algorithm for this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants