Skip to content

showing custom tokens in swap history #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgrabina
Copy link
Contributor

@mgrabina mgrabina commented Jun 6, 2025

image

Closes AAVE-572

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 2:43pm

Copy link

linear bot commented Jun 6, 2025

@mgrabina mgrabina force-pushed the feat/custom-tokens-in-history branch from 280e408 to 51bbb15 Compare June 6, 2025 22:03
@mgrabina mgrabina marked this pull request as ready for review June 6, 2025 22:06
Copy link

github-actions bot commented Jun 6, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +568 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 6, 2025

Copy link

github-actions bot commented Jun 9, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +558 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 9, 2025

Copy link

github-actions bot commented Jun 9, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +558 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 9, 2025

Copy link

github-actions bot commented Jun 9, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +538 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 9, 2025

Copy link

github-actions bot commented Jun 9, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +538 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 9, 2025

@mgrabina mgrabina force-pushed the feat/custom-tokens-in-history branch from d5189b4 to 9a502cc Compare June 9, 2025 14:33
Copy link

github-actions bot commented Jun 9, 2025

Copy link

github-actions bot commented Jun 9, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +538 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 9, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +561 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 50.41 KB (-1 B) 1.44 MB
/faucet 14.86 KB (-1 B) 1.41 MB
/governance/v3/proposal 122.83 KB (-1 B) 1.51 MB
/markets 31.19 KB (-1 B) 1.42 MB
/safety-module 38.2 KB (🟡 +200 B) 1.43 MB
/staking 30.67 KB (🟡 +206 B) 1.42 MB
/v3-migration 34.07 KB (🟡 +1 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant