Divisions turned into multiplications #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As correctly stated by Mausy5043, the division is quite slow in most microcontrollers, so I have replaced them with multiplications.
|
Thanks for submitting the change! Gave it a quick test and it looks great. I didn't check the speed, but can see how it might be a teeny bit faster. One thing though I switched the array indexing back to integer division by 8 since we don't really want a floating point value there (and the compiler is probably optimizing it into a couple bit shifts anyways). Thanks again for contributing! |
|
I can't believe that I made such a mistake with the array index. Thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As correctly stated by @Mausy5043, the division is quite slow in most
microcontrollers, so I have replaced them with multiplications.