-
Notifications
You must be signed in to change notification settings - Fork 642
Fix download links for RP2040 Feather ThinkInk #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could we make a system to allow for name changes? Dan and I were talking about changing some older board names to include manufacturer. It'd be cool to redirect from the old name to the new and manages the download link based on version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for now. Thanks!
Not easily, but probably. The Liquid language that Jekyll uses generates static pages based on the info in the .md files. The pages that appear to be dynamic such as the unknown page and the installer are done purely with JavaScript. To have it deal with the updates would require rewriting the Liquid code that generates the static pages so that it more heavily relies on the data files, which may not be such a bad idea really. Currently the code is very patchy, making introducing bugs a little too easy. I would like to take some time to clean it up. It would mostly just take some time because Liquid is not intuitive. I can create an issue for now. |
We could consider abandoning Jekyll and Liquid all together. I think the static site generation options got much more flexible with GitHub actions. |
Hmm, I'd be ok with that. I'll need to take a look at the other options to see what would might meet our needs better. |
There does appear to be a plugin for adding redirects in a simple way. no idea if it works. https://github.com/jekyll/jekyll-redirect-from |
Good to know for updating the epd board back to thinkink, but it could cause things to get complicated if we overuse it. I think the idea is to make something that doesn't take so much maintenance to work properly. |
Fixes #1199. Apparently in the previous releases it was called
adafruit_feather_rp2040_epd
, but in future releases will be calledadafruit_feather_rp2040_thinkink
because of adafruit/circuitpython#7927. I had to change it toadafruit_feather_rp2040_epd
for now, but it will need to be reverted on the next release.