Skip to content

update frozen libs for 7.3.2 #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

update frozen libs for 7.3.2 #6619

merged 1 commit into from
Jul 20, 2022

Conversation

dhalbert
Copy link
Collaborator

Update frozen modules to fix various ESP32SPI and request issues with frozen modules on 7.3.1.

@dhalbert dhalbert marked this pull request as ready for review July 19, 2022 16:56
@dhalbert dhalbert requested review from jepler and kattni July 19, 2022 23:12
@dhalbert
Copy link
Collaborator Author

Smoke-tested wifi on PyPortal. It connects.

jepler
jepler approved these changes Jul 20, 2022
View reviewed changes
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirmed that these updates look right. Didn't do any testing.

@jepler
Copy link

jepler commented Jul 20, 2022

Note that when using gitk or git show -p --submodule=log to review submodule changes, it can incorrectly show that a submodule has had commits be removed from it. Before doing this, "unshallow" all the related submodules.

Typical incorrect change shown in gitk:
image

@dhalbert
Copy link
Collaborator Author

How do you unshallow a particular submodule? I did a websearch for this and came up empty.

@dhalbert dhalbert merged commit 4a5790b into adafruit:7.3.x Jul 20, 2022
@dhalbert dhalbert deleted the 7.3.x-update-frozen branch July 20, 2022 16:09
@dhalbert dhalbert mentioned this pull request Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

@kattni kattni Awaiting requested review from kattni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @jepler