Skip to content

Update 42. Keebs Frood support for Rev7 #8154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

piit79
Copy link

@piit79 piit79 commented Jul 10, 2023

  1. Keebs Frood Rev7 uses a new 4 MB flash chip (Winbond W25Q32JVUUIQ)

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to list the flash chip of all revisions here, separated by commas:

EXTERNAL_FLASH_DEVICES = "ZD25WQ16B, W25Q64JVxQ"

Otherwise, I think that running this on an older revision board with the ZD... chip would fail.

Typical example from an adafruit board:

ports/atmel-samd/boards/circuitplayground_express/mpconfigboard.mk:EXTERNAL_FLASH_DEVICES = "S25FL216K, GD25Q16C"

The syntax seems to be written "A","B" in some places and "A, B" in others. I'd use the syntax shown above.

@dhalbert
Copy link
Collaborator

W25Q64JVUUIQ is 8MB (64 Mbit). This new build will not work on the old boards with 2MB flash. Or are there no old boards?

@piit79
Copy link
Author

piit79 commented Jul 10, 2023

Thanks @jepler, I had no idea I could do that! The firmware indeed works with both the new (Winbond 4 MB) and the old (Zetta 2 MB) board revisions.

@piit79
Copy link
Author

piit79 commented Jul 10, 2023

Thanks for spotting that, @dhalbert - I copied the wrong device identifier. The latest revision of my board uses W25Q32JVUUIQ, a 4 MB chip.

Funnily enough CircuitPython did actually work with the wrong second device identifier on both the old (2 MB) and the new (4 MB) boards in a simple "LED blink" test...

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants