Use a different way to force building sdkconfig early #8310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `Makefile:...` version broke the shared bindings matrix generation, as it would fail if esp-idf wasn't in the environment (and we wouldn't want it to do that much work anyway)
This can affect whether the shared-bindings-matrix works, as in the case of this PR.
dhalbert
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
Makefile:...version broke the shared bindings matrix generation, as it would fail if esp-idf wasn't in the environment (and we wouldn't want it to do that much work anyway).. and the CI is modified so that changing a Makefile or a .mk file will build docs; this would have exposed the problem earlier.