Remove frozen libs from Funhouse #8348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to do this on 8.2.x instead? |
|
Would it get propagated to main eventually? If so, yes. |
|
I think I would need to start with branching off 8.2.x to make that change. |
|
Closing this. It'll be merged into main with the rest of 8.2.x. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the last time a release was done with 8.2.4, the frozen libs were not updated which is causing problems with boards like the FunHouse because the version that is frozen is not compatible with settings.toml.
This was originally added when we were experiencing some issues with certain boards that used PortalBase. The M4 PortalBase boards (PyPortal MatrixPortal M4) still need this, but esp32-s2 boards have plenty of RAM and don't really need it. In order to make it easier to update, this PR just removes the frozen libs from the funhouse.