Skip to content

Fix MDNS after the user turns off wifi #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 20, 2023

We need to reset our MDNS state instead of just the IDF's.

@tannewt tannewt mentioned this pull request Sep 20, 2023
We need to reset our MDNS state instead of just the IDF's.
@tannewt tannewt force-pushed the fix_mdns_crash_after_user_disconnect branch from 8e97c7b to 8f3c642 Compare September 20, 2023 21:46
@tannewt tannewt marked this pull request as ready for review September 20, 2023 21:47
@tannewt tannewt requested a review from dhalbert September 20, 2023 21:47
@tannewt
Copy link
Member Author

tannewt commented Sep 20, 2023

Issue found by @bill88t

@bill88t
Copy link

bill88t commented Sep 20, 2023

This actually completely fixes the issue! No further changes are needed.
Mdns now recovers from .stop_station(), .enabled=0 and disconnections due to range.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense -didn't test.

@dhalbert dhalbert merged commit 37180b2 into adafruit:8.2.x Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants