Dotclock enhancements #8430

jepler · 2023-09-25T16:38:29Z

Fix releasing dot clock framebuffers at soft reset (a possible cause of "ValueError: GPIO2 in use")
add support for a reset pin on the IO expander
re-order the arguments & add board.TFT_IO_EXPANDER to ease calling ioexpander_send_init_sequence

Closes #8428 @ladyada
I noticed that the dot clock can be increased to 16MHz without causing screen tearing in my demo 🎉 @tannewt

The Espressif LCD EV needs to be updated with board.TFT_IO_EXPANDER, which is why I'm creating this in draft mode. This does make an incompatible change to ioexpander_send_init_sequence but that has not been in a stable release and only applies to boards hardly anybody has so it's fine.

Test program with Qualia (rev B), tl021wvc02 round display and this PR:

from displayio import release_displays
release_displays()

import time
import busio
import board
import digitalio
import microcontroller
import dotclockframebuffer
from framebufferio import FramebufferDisplay
from microcontroller import pin

init_sequence_tl021wvc02 = bytes((
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x10,
    0xc0, 0x02, 0x3b, 0x00,
    0xc1, 0x02, 0x0b, 0x02,
    0xc2, 0x02, 0x00, 0x02,
    0xcc, 0x01, 0x10,
    0xcd, 0x01, 0x08,
    0xb0, 0x10, 0x02, 0x13, 0x1b, 0x0d, 0x10, 0x05, 0x08, 0x07, 0x07, 0x24, 0x04, 0x11, 0x0e, 0x2c, 0x33, 0x1d,
    0xb1, 0x10, 0x05, 0x13, 0x1b, 0x0d, 0x11, 0x05, 0x08, 0x07, 0x07, 0x24, 0x04, 0x11, 0x0e, 0x2c, 0x33, 0x1d,
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x11,
    0xb0, 0x01, 0x5d,
    0xb1, 0x01, 0x43,
    0xb2, 0x01, 0x81,
    0xb3, 0x01, 0x80,
    0xb5, 0x01, 0x43,
    0xb7, 0x01, 0x85,
    0xb8, 0x01, 0x20,
    0xc1, 0x01, 0x78,
    0xc2, 0x01, 0x78,
    0xd0, 0x01, 0x88,
    0xe0, 0x03, 0x00, 0x00, 0x02,
    0xe1, 0x0b, 0x03, 0xa0, 0x00, 0x00, 0x04, 0xa0, 0x00, 0x00, 0x00, 0x20, 0x20,
    0xe2, 0x0d, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xe3, 0x04, 0x00, 0x00, 0x11, 0x00,
    0xe4, 0x02, 0x22, 0x00,
    0xe5, 0x10, 0x05, 0xec, 0xa0, 0xa0, 0x07, 0xee, 0xa0, 0xa0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xe6, 0x04, 0x00, 0x00, 0x11, 0x00,
    0xe7, 0x02, 0x22, 0x00,
    0xe8, 0x10, 0x06, 0xed, 0xa0, 0xa0, 0x08, 0xef, 0xa0, 0xa0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xeb, 0x07, 0x00, 0x00, 0x40, 0x40, 0x00, 0x00, 0x00,
    0xed, 0x10, 0xff, 0xff, 0xff, 0xba, 0x0a, 0xbf, 0x45, 0xff, 0xff, 0x54, 0xfb, 0xa0, 0xab, 0xff, 0xff, 0xff,
    0xef, 0x06, 0x10, 0x0d, 0x04, 0x08, 0x3f, 0x1f,
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x13,
    0xef, 0x01, 0x08,
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x00,
    0x36, 0x01, 0x00,
    0x3a, 0x01, 0x60,
    0x11, 0x80, 0x64,
    0x29, 0x80, 0x32,
))


board.I2C().deinit()
i2c = busio.I2C(board.SCL, board.SDA) #, frequency=400_000)
tft_io_expander = dict(board.TFT_IO_EXPANDER)
tft_io_expander['i2c_address'] = 0x38 # uncomment for rev B, comment out for rev C
dotclockframebuffer.ioexpander_send_init_sequence(i2c, init_sequence_tl021wvc02, **tft_io_expander)
i2c.deinit()

tft_pins = dict(board.TFT_PINS)

tft_timings = {
    "frequency": 16_000_000,
    "width": 480,
    "height": 480,
    "hsync_pulse_width": 20,
    "hsync_front_porch": 40,
    "hsync_back_porch": 40,
    "vsync_pulse_width": 10,
    "vsync_front_porch": 40,
    "vsync_back_porch": 40,
    "hsync_idle_low": False,
    "vsync_idle_low": False,
    "de_idle_high": False,
    "pclk_active_high": True,
    "pclk_idle_high": False,
}

fb = dotclockframebuffer.DotClockFramebuffer(**tft_pins, **tft_timings)
disp = FramebufferDisplay(fb, auto_refresh=False)

while True:
    print("\n" * 24)
    for k, v in tft_pins.items():
        print(f"{k:<20} {v}")
    disp.auto_refresh = True
    time.sleep(6)
    disp.auto_refresh = False
    print("\n" * 24)
    for k, v in tft_timings.items():
        print(f"{k:<20} {v}")
    disp.auto_refresh = True
    time.sleep(6)
    disp.auto_refresh = False

this caused problems particularly when the framebuffer was not associated with a display.

* can now send the I2C bus initialization code * can now reset the display on an I/O expander pin * parameters re-ordered to enable easy use with **board.TFT_IO_EXPANDER

these arguments make it easier to call ioexpander_send_init_sequence

this "should" turn permanent tearing into temporary tearing.

Otherwise, a stack-constructed i2c instance might get some other value here.

jepler · 2023-09-26T13:43:08Z

Branch updated, as is the code for Qualia in the initial comment. Note that for rev C boards you'll need to comment out the line setting the i2c address to 0x38.

tannewt

Looks good to me and I got it working! Thank you!

ladyada · 2023-09-27T18:51:29Z

mooooon clock demo:

import displayio
displayio.release_displays()

import time
import busio
import board
import digitalio
import os
import ipaddress
import ssl
import wifi
import microcontroller
import socketpool
import adafruit_requests
import adafruit_imageload
import dotclockframebuffer
from framebufferio import FramebufferDisplay
from microcontroller import pin

init_sequence_tl021wvc02 = bytes((
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x10,
    0xc0, 0x02, 0x3b, 0x00,
    0xc1, 0x02, 0x0b, 0x02,
    0xc2, 0x02, 0x00, 0x02,
    0xcc, 0x01, 0x10,
    0xcd, 0x01, 0x08,
    0xb0, 0x10, 0x02, 0x13, 0x1b, 0x0d, 0x10, 0x05, 0x08, 0x07, 0x07, 0x24, 0x04, 0x11, 0x0e, 0x2c, 0x33, 0x1d,
    0xb1, 0x10, 0x05, 0x13, 0x1b, 0x0d, 0x11, 0x05, 0x08, 0x07, 0x07, 0x24, 0x04, 0x11, 0x0e, 0x2c, 0x33, 0x1d,
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x11,
    0xb0, 0x01, 0x5d,
    0xb1, 0x01, 0x43,
    0xb2, 0x01, 0x81,
    0xb3, 0x01, 0x80,
    0xb5, 0x01, 0x43,
    0xb7, 0x01, 0x85,
    0xb8, 0x01, 0x20,
    0xc1, 0x01, 0x78,
    0xc2, 0x01, 0x78,
    0xd0, 0x01, 0x88,
    0xe0, 0x03, 0x00, 0x00, 0x02,
    0xe1, 0x0b, 0x03, 0xa0, 0x00, 0x00, 0x04, 0xa0, 0x00, 0x00, 0x00, 0x20, 0x20,
    0xe2, 0x0d, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xe3, 0x04, 0x00, 0x00, 0x11, 0x00,
    0xe4, 0x02, 0x22, 0x00,
    0xe5, 0x10, 0x05, 0xec, 0xa0, 0xa0, 0x07, 0xee, 0xa0, 0xa0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xe6, 0x04, 0x00, 0x00, 0x11, 0x00,
    0xe7, 0x02, 0x22, 0x00,
    0xe8, 0x10, 0x06, 0xed, 0xa0, 0xa0, 0x08, 0xef, 0xa0, 0xa0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xeb, 0x07, 0x00, 0x00, 0x40, 0x40, 0x00, 0x00, 0x00,
    0xed, 0x10, 0xff, 0xff, 0xff, 0xba, 0x0a, 0xbf, 0x45, 0xff, 0xff, 0x54, 0xfb, 0xa0, 0xab, 0xff, 0xff, 0xff,
    0xef, 0x06, 0x10, 0x0d, 0x04, 0x08, 0x3f, 0x1f,
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x13,
    0xef, 0x01, 0x08,
    0xff, 0x05, 0x77, 0x01, 0x00, 0x00, 0x00,
    0x36, 0x01, 0x00,
    0x3a, 0x01, 0x60,
    0x11, 0x80, 0x64,
    0x29, 0x80, 0x32,
))


board.I2C().deinit()
i2c = busio.I2C(board.SCL, board.SDA) #, frequency=400_000)
tft_io_expander = dict(board.TFT_IO_EXPANDER)
tft_io_expander['i2c_address'] = 0x38 # uncomment for rev B, comment out for rev C
dotclockframebuffer.ioexpander_send_init_sequence(i2c, init_sequence_tl021wvc02, **tft_io_expander)
i2c.deinit()

tft_pins = dict(board.TFT_PINS)

tft_timings = {
    "frequency": 16_000_000,
    "width": 480,
    "height": 480,
    "hsync_pulse_width": 20,
    "hsync_front_porch": 40,
    "hsync_back_porch": 40,
    "vsync_pulse_width": 10,
    "vsync_front_porch": 40,
    "vsync_back_porch": 40,
    "hsync_idle_low": False,
    "vsync_idle_low": False,
    "de_idle_high": False,
    "pclk_active_high": True,
    "pclk_idle_high": False,
}

fb = dotclockframebuffer.DotClockFramebuffer(**tft_pins, **tft_timings)
disp = FramebufferDisplay(fb, auto_refresh=False)

# URLs to fetch from
TEXT_URL = "http://wifitest.adafruit.com/testwifi/index.html"
JSON_QUOTES_URL = "https://www.adafruit.com/api/quotes.php"
JSON_STARS_URL = "https://api.github.com/repos/adafruit/circuitpython"

wifi.radio.stop_scanning_networks()
wifi.radio.connect(os.getenv("CIRCUITPY_WIFI_SSID"), os.getenv("CIRCUITPY_WIFI_PASSWORD"))

pool = socketpool.SocketPool(wifi.radio)
requests = adafruit_requests.Session(pool, ssl.create_default_context())

response = requests.get('http://www.geoplugin.net/json.gp').json()
LATITUDE = response['geoplugin_latitude']
LONGITUDE = response['geoplugin_longitude']
print('Using IP geolocation: ', LATITUDE, LONGITUDE)


url = 'https://api.met.no/weatherapi/sunrise/3.0/moon?lat=' + str(LATITUDE) + '&lon=' + str(LONGITUDE)
print(url)
response = requests.get(url).json()
phase = response['properties']['moonphase']
print(phase)

image, palette = adafruit_imageload.load("480fullmoon24.bmp")
tile_grid = displayio.TileGrid(image, pixel_shader=palette)
splash = displayio.Group()
splash.append(tile_grid)
disp.show(splash)
disp.refresh()

while True:
    pass

jepler added 4 commits September 25, 2023 09:45

displayio: fix releasing dot clock framebuffres in release_displays

409d1a8

this caused problems particularly when the framebuffer was not associated with a display.

Re-work ioexpander_send_init_sequence

04ad525

* can now send the I2C bus initialization code * can now reset the display on an I/O expander pin * parameters re-ordered to enable easy use with **board.TFT_IO_EXPANDER

On Qualia, define board.TFT_IO_EXPANDER

ce22edb

these arguments make it easier to call ioexpander_send_init_sequence

update io expander table for rev C

65310ab

tannewt self-requested a review September 25, 2023 20:50

jepler added 7 commits September 25, 2023 16:39

Switch to i2c init string for espressif lcd ev, expose values via board

6263f6a

enable LCD_RGB_RESTART_IN_VSYNC

747b6e8

this "should" turn permanent tearing into temporary tearing.

espressif: i2c: initialize "has_lock"

03141d4

Otherwise, a stack-constructed i2c instance might get some other value here.

bump ram to 120MHz

3af5cbc

Fix calculation of bit-weight for reset pin

6990c37

bump qualia psram to 120MHz

1c2362b

fix qualia board definition

3d3061f

jepler marked this pull request as ready for review September 26, 2023 13:43

tannewt approved these changes Sep 27, 2023

View reviewed changes

tannewt merged commit 3684640 into adafruit:main Sep 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dotclock enhancements #8430

Dotclock enhancements #8430

jepler commented Sep 25, 2023 •

edited

Loading

jepler commented Sep 26, 2023

tannewt left a comment

ladyada commented Sep 27, 2023

Dotclock enhancements #8430

Dotclock enhancements #8430

Conversation

jepler commented Sep 25, 2023 • edited Loading

jepler commented Sep 26, 2023

tannewt left a comment

Choose a reason for hiding this comment

ladyada commented Sep 27, 2023

jepler commented Sep 25, 2023 •

edited

Loading