RP2040: fix 8-bit WAV playback #8436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also subtly fixed 8- to 16-bit scaling math
tannewt
reviewed
Sep 27, 2023
There was a problem hiding this comment.
I was just in the ESP I2S code and it uses these helpers for conversion: https://github.com/adafruit/circuitpython/blob/main/shared-module/audiocore/__init__.c#L74
(They also don't handle the offset but are a good place to centralize this conversion.)
|
Actually, those helpers don't handle 10 bit output unfortunately. Will review this as-is. |
tannewt
requested changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for first half of issue #8432, the "buffer too small" exception. Also a minor change to the 8- to 16-bit scaling math that previously would cause a slight DC offset.
I can see where the second half of the aforementioned issue (.playing always True w/RawSample) is happening. Don’t have a fix for that yet, but if I can sort that out, and if before this is merged, will add it to this PR.