Skip to content

Fix pin adc unit check #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix pin adc unit check #8462

merged 1 commit into from
Oct 6, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 6, 2023

IDF5 made 0 valid. Use the NO_ADC macro instead

@tannewt
Fix pin adc unit check
15c5e8c 
IDF5 made 0 valid. Use the NO_ADC macro instead
@tannewt tannewt requested a review from dhalbert October 6, 2023 22:56
gamblor21
gamblor21 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watched you test it and change looks good. Just pending everything to build.

@gamblor21 gamblor21 merged commit f14ca95 into adafruit:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamblor21 gamblor21 gamblor21 approved these changes

@dhalbert dhalbert Awaiting requested review from dhalbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @gamblor21