Skip to content

Refine error message for rp2040 audiobusio I2S object creation #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Refine error message for rp2040 audiobusio I2S object creation #8466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0029617
Refine error message for rp2040 audiobusio I2S object creation
heygauri Oct 8, 2023
195867e
Merge remote-tracking branch 'adafruit/main' into fix-i2s-error-message
dhalbert Oct 14, 2023
e1d364d
merge from upstream
dhalbert Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions locale/circuitpython.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ msgid "Below minimum frame rate"
msgstr ""

#: ports/raspberrypi/common-hal/audiobusio/I2SOut.c
msgid "Bit clock and word select must be sequential pins"
msgid "Bit clock and word select must be sequential GPIO pins"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
Expand Down Expand Up @@ -1100,8 +1100,6 @@ msgstr ""
msgid "Generic Failure"
msgstr ""

#: shared-bindings/displayio/Display.c
#: shared-bindings/displayio/EPaperDisplay.c
#: shared-bindings/framebufferio/FramebufferDisplay.c
#: shared-module/displayio/Display.c
#: shared-module/framebufferio/FramebufferDisplay.c
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/audiobusio/I2SOut.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ void common_hal_audiobusio_i2sout_construct(audiobusio_i2sout_obj_t *self,
mp_raise_NotImplementedError_varg(translate("%q"), MP_QSTR_main_clock);
}
if (bit_clock->number != word_select->number - 1) {
mp_raise_ValueError(translate("Bit clock and word select must be sequential pins"));
mp_raise_ValueError(translate("Bit clock and word select must be sequential GPIO pins"));
}

const uint16_t *program = i2s_program;
Expand Down