Rename compressed_string_t to mp_rom_error_text_t to match upstream #8519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at the build errors in the next few days |
|
Are the errors are due to the substitution not removing the |
micropython puts the pointer-ness into the typedef; we can put the const-ness there too. this reduces the delta to micropython; for instance, emitinlinextensa and emitinlinethumb now match upstream.
|
I will merge this after the release of 9.0.0-alpha.2, since it is not a functionality change. |
dhalbert
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. and also use MP_ERROR_TEXT instead of translate in py/
this hopefully gets us a bit closer to upstream.
Closes #8511