Adds I2S mclk support to audiobusio.I2SOut for the Espressif port #8570 #8571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookfwd
changed the title
|
@lookfwd has reported this works with the built artifact. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8570.
In this commit, we address the issue of
NotImplementedError: main_clockthat occurs when attempting to use ESP32-S3 with the SGTL5000 audio codec. The problem arises when using theI2SOutfunctionality. To resolve this, we have ported an implementation similar to the mimxrt10xx's to the ESP32-S3 platform. Additionally, we have updated thecommon_hal_audiobusio_i2sout_deinitfunction in the same file to ensure proper cleanup.