Allow CIRCUITPY to mount on Android #8580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to test on iOS also? |
dhalbert
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Tested on an iPad running OS 17. Seems fine, works same before and after. On a Samsung Android 11 tablet, both a Trinket M0 (64kB) and a CIrcuit Playground Bluefruit work fine with the fix. They identify as "USB Storage 1", not CIRCUITPY, in the Files app.
This is a great advance. Thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the partition type code reported in the fake MBR for the CIRCUITPY filesystem from 0x01 to 0x06 allows CIRCUITPY to mount on an Android system. Resolves #2751 without switching to FAT16.
Tested on Android, MacOS, Windows and Linux.
Change does not affect existing CIRCUITPY filesystem on device.