-
Notifications
You must be signed in to change notification settings - Fork 1.3k
heltec esp32s3 wifi lora v3: new espressif board #8583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heltec esp32s3 wifi lora v3: new espressif board #8583
Conversation
0c5ba82
to
ab66aec
Compare
Do I need to request a |
|
Got it. Since this already has a USB VID and PID from espressif should I use the community documented VID & PID for espressif s3 boards? I think the issue - as I understand it - is that even though the VID and PID are defined, because I don't have a physical USB connected & disable that USB by default, a VID/PID are unexpected, defaulting to the creator ID / creation ID. So using the espressif space would make sense? |
The USB VID/PID are irrelevant since they will not be used. The creator ID should be based on the actual manufacturer, in this case, Heltec. When possible, we use the manufacturer's USB VID as part of the creator ID, but it sounds like they don't have their own VID? So just make up a creator ID -- anything that makes sense. Then for the creation ID, you could also see if there's a part number or something, or else just choose one. You might get some ideas from the other ones. |
ab66aec
to
c1af64a
Compare
Got it! I have updated this with the proposed creator ID & creation ID that I opened as a PR over in the creators repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One sdkconfig piece I don't think you need.
adds the Heltec ESP32S3 WiFi LoRa V3 as a supported espressif ESP32-S3FN8 board
this board features a Semtec SP1261 LoRa chip (over SPI) and an 0.96-inch 128*64 screen (over I2C)
the board doesn't connect USB by default and instead supports interactions via a CP210x over USB
the USB VID/PID was pulled from the creator's repository but it's the standard espressif VID and a PID I don't recognize
Datasheet can be found here