Skip to content

Rework ci_fetch_deps and use it from makefiles too #8589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jepler
Copy link

@jepler jepler commented Nov 12, 2023

  • teach ci_fetch_deps about --filter=blob:none
  • change logic ensuring tags in frozen/ are fetched
  • since check=True was all the time, remove unused kwarg
  • add fetch-board-submodules

Closes: #8588

 * teach ci_fetch_deps about --filter=blob:none
 * change logic ensuring tags in frozen/ are fetched
 * since check=True was all the time, remove unused kwarg
 * add fetch-board-submodules

Closes: adafruit#8588
@jepler jepler requested a review from microdev1 November 12, 2023 18:33
@microdev1 microdev1 requested review from tannewt and removed request for microdev1 November 14, 2023 14:02
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 4bdd3e6 into adafruit:main Nov 14, 2023


clone_supports_filter = (
False if "NO_USE_CLONE_FILTER" in os.environ else _git_version() >= (2, 27, 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch this: I thought the breakpoint was at 2.36.0 for partial clones, not 2.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of either fetch-submodules.sh or ci_fetch_deps.py
3 participants