Skip to content

Remove some stuff about reserved psram & supervisor allocations #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove some stuff about reserved psram & supervisor allocations
this is obsoleted by the new split heap code 🎉
  • Loading branch information
jepler committed Nov 13, 2023
commit fb840159fb7500b9e675585dbfa37920d8366bc8
3 changes: 0 additions & 3 deletions ports/espressif/bindings/espcamera/Camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@
//| """
//| Configure and initialize a camera with the given properties
//|
//| This driver requires that the ``CIRCUITPY_RESERVED_PSRAM`` in ``settings.toml`` be large enough to hold the camera framebuffer(s). Generally, boards with built-in cameras will have a default setting that is large enough. If the constructor raises a MemoryError or an IDFError, this probably indicates the setting is too small and should be increased.
//|
//|
//| .. important::
//|
//| Not all supported sensors have all
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,3 @@
#define DEFAULT_SPI_BUS_MISO (&pin_GPIO37)

#define DOUBLE_TAP_PIN (&pin_GPIO42)

#define DEFAULT_RESERVED_PSRAM (1048576)
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@
#define DEFAULT_SPI_BUS_MOSI (&pin_GPIO7)

#define DOUBLE_TAP_PIN (&pin_GPIO4)

// a 1024x768 16BPP framebuffer + some breathing room
#define DEFAULT_RESERVED_PSRAM (1024 * 1024 * 2)
2 changes: 0 additions & 2 deletions ports/espressif/boards/espressif_esp32_eye/mpconfigboard.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,3 @@
// UART pins attached to the USB-serial converter chip
#define CIRCUITPY_CONSOLE_UART_TX (&pin_GPIO1)
#define CIRCUITPY_CONSOLE_UART_RX (&pin_GPIO3)

#define DEFAULT_RESERVED_PSRAM (1048576)
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,3 @@
// UART pins attached to the USB-serial converter chip
#define CIRCUITPY_CONSOLE_UART_TX (&pin_GPIO43)
#define CIRCUITPY_CONSOLE_UART_RX (&pin_GPIO44)

// a 800x480 16BPP framebuffer + some breathing room
#define DEFAULT_RESERVED_PSRAM (800 * 800 * 2)
2 changes: 0 additions & 2 deletions ports/espressif/boards/espressif_esp32s3_eye/mpconfigboard.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,3 @@
{.clock = &pin_GPIO21, .mosi = &pin_GPIO47, .miso = NULL}, \
{.clock = &pin_GPIO39, .mosi = &pin_GPIO40, .miso = &pin_GPIO38}, \
}

#define DEFAULT_RESERVED_PSRAM (1048576)
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@
// UART pins attached to the USB-serial converter chip
#define CIRCUITPY_CONSOLE_UART_TX (&pin_GPIO43)
#define CIRCUITPY_CONSOLE_UART_RX (&pin_GPIO44)

// a 1024x768 16BPP framebuffer + some breathing room
#define DEFAULT_RESERVED_PSRAM (1024 * 1024 * 2)
3 changes: 0 additions & 3 deletions ports/espressif/boards/m5stack_timer_camera_x/mpconfigboard.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,3 @@
#define CIRCUITPY_CONSOLE_UART_RX (&pin_GPIO3)

#define CIRCUITPY_I2C_ALLOW_INTERNAL_PULL_UP (1)

// espcamera.FrameSize.QXGA, half a megabyte result image.jpeg
#define DEFAULT_RESERVED_PSRAM (1572864)
3 changes: 0 additions & 3 deletions ports/espressif/boards/makerfabs_tft7/mpconfigboard.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,3 @@
// UART pins attached to the USB-serial converter chip
#define CIRCUITPY_CONSOLE_UART_TX (&pin_GPIO43)
#define CIRCUITPY_CONSOLE_UART_RX (&pin_GPIO44)

// a 1024x768 16BPP framebuffer + some breathing room
#define DEFAULT_RESERVED_PSRAM (1024 * 1024 * 2)
1 change: 0 additions & 1 deletion ports/espressif/common-hal/espidf/__init__.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
#else
#define esp_himem_reserved_area_size() (0)
#endif
size_t reserved_psram = DEFAULT_RESERVED_PSRAM;
#endif

static size_t psram_size_usable(void) {
Expand Down
9 changes: 0 additions & 9 deletions ports/espressif/mpconfigport.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,4 @@
#define CIRCUITPY_I2C_ALLOW_INTERNAL_PULL_UP (0)
#endif

#ifndef DEFAULT_RESERVED_PSRAM
#define DEFAULT_RESERVED_PSRAM (0)
#endif

#if defined(CONFIG_SPIRAM)
#undef CIRCUITPY_PORT_NUM_SUPERVISOR_ALLOCATIONS
#define CIRCUITPY_PORT_NUM_SUPERVISOR_ALLOCATIONS (1)
#endif

#endif // MICROPY_INCLUDED_ESPRESSIF_MPCONFIGPORT_H
4 changes: 0 additions & 4 deletions py/circuitpy_mpconfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -545,10 +545,6 @@ void background_callback_run_all(void);
#error "CIRCUITPY_USB_HID_MAX_REPORT_IDS_PER_DESCRIPTOR must be at least 1"
#endif

#ifndef CIRCUITPY_PORT_NUM_SUPERVISOR_ALLOCATIONS
#define CIRCUITPY_PORT_NUM_SUPERVISOR_ALLOCATIONS (0)
#endif

#ifndef USB_MIDI_EP_NUM_OUT
#define USB_MIDI_EP_NUM_OUT (0)
#endif
Expand Down