Skip to content

Don't put comments on mpconfigboard.mk lines; add mistaken flash chip for HalloWing M0 #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Don't put comments on mpconfigboard.mk lines; add mistaken flash chip for HalloWing M0 #8669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ports/atmel-samd/boards/hallowing_m0_express/mpconfigboard.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ CHIP_VARIANT = SAMD21G18A
CHIP_FAMILY = samd21

SPI_FLASH_FILESYSTEM = 1
EXTERNAL_FLASH_DEVICES = "W25Q64JVxQ, GD25Q64C"
EXTERNAL_FLASH_DEVICES = "W25Q64JVxQ, GD25Q64C, W25Q16JVxQ"
LONGINT_IMPL = NONE

# To keep the build small
CIRCUITPY_AUDIOBUSIO = 0
CIRCUITPY_BUSDEVICE = 1 # lis3dh needs it
# lis3dh needs adafruit_bus_device
CIRCUITPY_BUSDEVICE = 1
CIRCUITPY_KEYPAD = 0

# Include these Python libraries in firmware.
Expand Down
12 changes: 8 additions & 4 deletions ports/atmel-samd/boards/seeeduino_xiao_kb/mpconfigboard.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,19 @@ CIRCUITPY_FULL_BUILD = 0
# Many I/O functions are not available or not used in a keyboard
# CIRCUITPY_ANALOGIO = 1 # Needed for potentiometer input (mouse)
CIRCUITPY_AUDIOCORE = 0
CIRCUITPY_BUSIO = 0 # Needed for I2C, SPI and UART - removed that for keyboards...
# Needed for I2C, SPI and UART - removed that for keyboards...
CIRCUITPY_BUSIO = 0
CIRCUITPY_PULSEIO = 0
# CIRCUITPY_PWMIO = 1 # only needed for speaker or LED PWM functions. Takes 2314 bytes.
# only needed for speaker or LED PWM functions. Takes 2314 bytes.
# CIRCUITPY_PWMIO = 1
CIRCUITPY_RTC = 0
CIRCUITPY_MATH = 0
#CIRCUITPY_RANDOM = 0
CIRCUITPY_ONEWIREIO = 0
CIRCUITPY_NEOPIXEL_WRITE = 1 # Needed for RGB LEDs
CIRCUITPY_RAINBOWIO = 1 # Needed for RGB LEDs
# Needed for RGB LEDs
CIRCUITPY_NEOPIXEL_WRITE = 1
# Needed for RGB LEDs
CIRCUITPY_RAINBOWIO = 1
# These are used in a keyboard or computer input device.
CIRCUITPY_ROTARYIO = 1
CIRCUITPY_KEYPAD = 1
Expand Down
5 changes: 4 additions & 1 deletion ports/stm/boards/stm32f411ce_blackpill/mpconfigboard.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ USB_PRODUCT = "stm32f411ce blackpill"
USB_MANUFACTURER = "WeAct"

# SPI_FLASH_FILESYSTEM = 1
# EXTERNAL_FLASH_DEVICES = xxxxxx #See supervisor/shared/external_flash/devices.h for options

# See supervisor/shared/external_flash/devices.h for options
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[I know this was already merged, but: I think this comment is out of date, this info is in nvm.toml now]

# EXTERNAL_FLASH_DEVICES = xxxxxx

# LONGINT_IMPL = MPZ

INTERNAL_FLASH_FILESYSTEM = 1
Expand Down